RFR: 8308031: Linkers should promote variadic arguments [v6]

[Jorn Vernee]

On Fri, 2 Jun 2023 15:47:05 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into VAFixes
>>  - undo spurious whitespace changes
>>  - automatically apply variadic promotions
>>  - move prototype-less name
>>  - Rework javadoc
>>  - review comments
>>  - fix word order
>>  - adjust whitespace
>>  - simplify test changes
>>  - reject invalid variadic layouts
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/973fe55b...9daadbfc
>
> src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java line 327:
> 
>> 325:     }
>> 326: 
>> 327:     private static boolean requiresVariadicFloatPromotion(ValueLayout vl) {
> 
> Should this be called `requiresVariadicDoublePromotion` ? (In the other method we say `int`, which is the target of the conversion).

Yes, I can do that. I was going for 'int' meaning 'integral' and 'float' meaning floating point. But I think your suggestion is clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14225#discussion_r1214553721