RFR: 8309216: Cast from jchar* to char* in test java/io/GetXSpace.java [v2]
Brian Burkhalter
bpb at openjdk.org
Fri Jun 2 22:31:05 UTC 2023
On Fri, 2 Jun 2023 22:23:12 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Probably not. This is only intended to cover the constrained case of this test. Something like the macro `WITH_PLATFORM_STRING` in `libjava/io_util.h` would be needed for the general case, but I thought that that might be overdoing it for here. I could of course be mistaken.
>
> OK, if the usage is limited and covers the required test cases, that sounds reasonable.
Only file system roots are passed as the paths handed to the `getSpace0()` method so hopefully it should be all right.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14276#discussion_r1214903127
More information about the core-libs-dev
mailing list