RFR: 8309334: ProcessTools.main() does not properly set thread names when using the virtual thread wrapper [v3]

[Serguei Spitsyn]

On Sat, 3 Jun 2023 21:34:16 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Normally when a virtual thread wrapper is used to run a test, the main thread is renamed to "old-m-a-i-n" and the new virtual thread that will act as the main thread is named "main". Neither is being done by `ProcessTools.main()`. This can cause problems for tests that expect the main thread that the test is running in to be called "main". It is instead left unnamed. This is causing the following 4 tests to fail:
>> 
>> com/sun/jdi/JdbMethodExitTest.java
>> com/sun/jdi/JdbStepTest.java
>> com/sun/jdi/JdbStopThreadTest.java
>> com/sun/jdi/JdbStopThreadidTest.java
>> 
>> These tests also fail due to [JDK-8309397](https://bugs.openjdk.org/browse/JDK-8309397), which will be fixed after this CR, and also com/sun/jdi/JdbMethodExitTest.java fails due to [JDK-8309396](https://bugs.openjdk.org/browse/JDK-8309396), which will also subsequently be fixed.
>> 
>> Note this fix messed up one runtime test. It was expecting an exception message to mention the "main" thread rather than "old-m-a-i-n". Loosening the exception message matching pattern a bit solved the problem.
>> 
>> Testing was done by running all of tier1 and tier5.
>
> Chris Plummer has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - No longer need reflection to call Thread.ofVirtual().unstarted()
>  - Remove from problem list tests that are fixed by this PR.

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14292#pullrequestreview-1460389726