RFR: JDK-8308913: Update core reflection for JEP 445 (preview) [v4]
Jim Laskey
jlaskey at openjdk.org
Mon Jun 5 12:51:11 UTC 2023
On Mon, 5 Jun 2023 10:08:59 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 29:
>
>> 27:
>> 28: import jdk.internal.javac.PreviewFeature;
>> 29: import jdk.internal.misc.PreviewFeatures;
>
> Can you move this so that it's with the other imports of jdk.internal classes?
Changing in primary PR - https://github.com/openjdk/jdk/pull/13689
> src/java.base/share/classes/java/lang/Class.java line 194:
>
>> 192: * <h2><a id=unnamedClasses>Unnamed Classes</a></h2>
>> 193: *
>> 194: * A {@code class} file representing an {@linkplain #isUnnamedClass unnamed class} is generated by
>
> Are you going to reflow this paragraph before you are done, only wondering as there is one line sticking out compared the rest of the paragraph.
Changing in primary PR - https://github.com/openjdk/jdk/pull/13689
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1218025885
PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1218027536
More information about the core-libs-dev
mailing list