RFR: JDK-8308913: Update core reflection for JEP 445 (preview) [v4]

Jim Laskey jlaskey at openjdk.org
Mon Jun 5 13:00:08 UTC 2023


On Mon, 5 Jun 2023 10:17:01 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update reflective support.
>
> src/java.base/share/classes/java/lang/Class.java line 216:
> 
>> 214:  * {@linkplain #getSimpleName
>> 215:  * simple name} of such an unnamed class is the empty string and the
>> 216:  * {@linkplain #getCanonicalName canonical name} is {@code null}.
> 
> This sentence is quite long. You might to consider splitting it up, or at minimally put a comma after "empty string" to allow the reader draw breath.

This was the agreed wording.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14165#discussion_r1218038932


More information about the core-libs-dev mailing list