RFR: 8309532: java/lang/Class/getDeclaredField/FieldSetAccessibleTest should filter modules that depend on JVMCI

Mandy Chung mchung at openjdk.org
Wed Jun 7 17:34:12 UTC 2023


On Wed, 7 Jun 2023 16:59:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> `FieldSetAccessibleTest` attempts to load all JDK classes and test `setAccessible` on their public fields to work properly.   It should filter the modules that directly and indirectly depend on `jdk.internal.vm.compiler` and  `jdk.internal.vm.compiler.management` as they are upgradeable and also provide APIs to add qualifed exports dynamically.
>
> test/jdk/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java line 314:
> 
>> 312:             });
>> 313: 
>> 314:             Set<String> deployModules = Set.of("javafx.deploy", "jdk.deploy", "jdk.plugin", "jdk.javaws");
> 
> Can deployModules be dropped?

There are two other tests that should be updated.  I updated this one in this PR.  Will create another PR to drop those.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14362#discussion_r1221937427


More information about the core-libs-dev mailing list