RFR: 8285368: Overhaul doc-comment inheritance [v2]

Pavel Rappo prappo at openjdk.org
Wed Jun 7 20:54:52 UTC 2023


On Wed, 7 Jun 2023 19:13:55 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback: make warning less scary
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java line 671:
> 
>> 669: //                .anyMatch(t -> Objects.equals(typeUtils.asElement(t), typeUtils.asElement(t2)));
>> 670: 
>> 671:         return true; /* disabled for causing issues in JDK API Documentation build */
> 
> Please describe the issues and/or provide a JBS issue, so that we can decide when to revert the code to the commented-out form.

I mentioned it in the test, here: TestDirectedInheritance.testNotDirectSupertype. I reckon referring to code from a test is okay, but not the other way around.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14357#discussion_r1222148500


More information about the core-libs-dev mailing list