RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration

Benjamin Marwell duke at openjdk.org
Fri Jun 9 07:27:09 UTC 2023


On Mon, 19 Dec 2022 11:26:25 GMT, Romain Manni-Bucau <duke at openjdk.org> wrote:

> enumeration(list) will create an enumeration, a list and an iterator whereas the impl only requires an iterator
> this PR drops the enumeration wrapper for binary constructor and just maps the enumeration to an iterator for the other case which should be a better compromise in practise.
> 
> Another side but nice effect is to have some lighter classloading (subgraph)

Greatly spotted! 👍🏻
This will also introduce a new constructor which is much more handy than the previous ones.

bump - forgot to send a mail to the mailing list.

bump

-------------

Marked as reviewed by bmarwell at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jdk/pull/11718#pullrequestreview-1222737433
PR Comment: https://git.openjdk.org/jdk/pull/11718#issuecomment-1500913999
PR Comment: https://git.openjdk.org/jdk/pull/11718#issuecomment-1584022022


More information about the core-libs-dev mailing list