RFR: 8305947: SequenceInputStream implementation can use an Iterator rather than Enumeration
Jaikiran Pai
jpai at openjdk.org
Fri Jun 9 07:27:09 UTC 2023
On Mon, 16 Jan 2023 19:21:36 GMT, Romain Manni-Bucau <duke at openjdk.org> wrote:
>> enumeration(list) will create an enumeration, a list and an iterator whereas the impl only requires an iterator
>> this PR drops the enumeration wrapper for binary constructor and just maps the enumeration to an iterator for the other case which should be a better compromise in practise.
>>
>> Another side but nice effect is to have some lighter classloading (subgraph)
>
> Still hope it can make it to the jdk.
Hello @rmannibucau, PRs which do not have a corresponding bug tracker issue, don't trigger the review process (backed by bots). Typically, for obvious fixes/changes, someone with access to the JDK issue tracker creates a issue and then helps the PR author to update the PR title to match that bug id and summary.
In cases like this current one, where it isn't clear whether this change is necessary, it's recommended that the change be first discussed in the relevant dev mailing list before creating a JDK issue (and proposing the PR) for it.
For the current change, core-libs-dev is the right mailing list https://mail.openjdk.org/mailman/listinfo/core-libs-dev. Could you please open a discussion there about this change and request for inputs? You will have to subscribe to that list first.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/11718#issuecomment-1401467296
More information about the core-libs-dev
mailing list