RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]
Viktor Klang
duke at openjdk.org
Fri Jun 9 10:09:42 UTC 2023
On Fri, 9 Jun 2023 09:45:33 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Decresing the number of iterations proportional to the increase in the max memory size
>
> Did you test if this significantly changed the execution time of the test? I'm wondering if it would make sense to change this to something smaller, say `maxMemory / 32`?
@stefank Good point. The runtime didn't meaningfully change on my own machine, but I've now decresed the iterations proportionally to the memory, and made sure that it still errors out (locally) if it doesn't GC the tasks.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14389#issuecomment-1584320889
More information about the core-libs-dev
mailing list