RFR: JDK-8308047 java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors [v2]

Stefan Karlsson stefank at openjdk.org
Fri Jun 9 11:56:49 UTC 2023


On Fri, 9 Jun 2023 10:07:31 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> The test used a too-small heap for generic testing, and coupled with looking at `freeMemory()` it led to a less-than-ideal determinism of execution of the test.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Decresing the number of iterations proportional to the increase in the max memory size

I'm happy with the changes, but make sure to get a Review from one of the maintainers of this code area. Thanks.

-------------

Marked as reviewed by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14389#pullrequestreview-1471817200


More information about the core-libs-dev mailing list