RFR: 8281658: Add a security category to the java -XshowSettings option

Weijun Wang weijun at openjdk.org
Sat Jun 10 14:44:42 UTC 2023


On Fri, 9 Jun 2023 13:54:14 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> New functionality in the -XshowSettings menu to display relevant information about JDK security configuration

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 349:

> 347:                 // split lines longer than 60 chars which have multiple values
> 348:                 ostream.println(TWOINDENT + key + "=");
> 349:                 List.of(val.split(",")).forEach(s -> ostream.println(THREEINDENT + s.trim()));

You should probably add back `,` when printing them out.

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 381:

> 379:     private static void printSecurityProviderConfig() {
> 380:         ostream.println(INDENT + "Security provider static configuration:");
> 381:         for (Provider p : Security.getProviders()) {

Maybe add an empty line or something like `-----` between providers?

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 385:

> 383:             ostream.println(TWOINDENT + "Provider information: " + wrappedString(p.getInfo(), 80));
> 384:             ostream.println(TWOINDENT + "Provider services: (type : algorithm)");
> 385:             for (Provider.Service ps : p.getServices().stream()

If this stream is empty, should you print out something like "none"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1225400656
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1225401386
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1225401803


More information about the core-libs-dev mailing list