RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v2]
Oliver Kopp
duke at openjdk.org
Mon Jun 12 05:47:45 UTC 2023
On Mon, 12 Jun 2023 05:02:07 GMT, Alan Bateman <alanb at openjdk.org> wrote:
> Do you mind fixing all the comments as these 160+ lines
Done. I copied the (for me) important comments to the GitHub reply https://github.com/openjdk/jdk/pull/14408#issuecomment-1586615579.
> You had fixed that in the original PR but it looks like they have come back with this PR.
This is my job training 😇: Comment the core ideas (and do not verbatim repeat what is said by the code directly). - For me, the good thing is, the diff now has all the comments (https://github.com/openjdk/jdk/pull/14408/commits/23bbc0ce0c8fd8a4cd689c0260c5fbcb91b20046). OK, at least one has go to nirvana in all cases.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14408#discussion_r1226108776
More information about the core-libs-dev
mailing list