RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v2]

Naoto Sato naoto at openjdk.org
Mon Jun 12 17:33:11 UTC 2023


> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the in-house cache with WeakHashMap, and removed the Key class as it is no longer needed (thus the original NPE will no longer be possible). Also with the new JMH test case, it gains some performance improvement:
> 
> (w/o fix)
> 
> Benchmark                       Mode  Cnt      Score     Error  Units
> LocaleCache.testForLanguageTag  avgt   20   5781.275 ± 569.580  ns/op
> LocaleCache.testLocaleOf        avgt   20  62564.079 ± 406.697  ns/op
> 
> (w/ fix)
> Benchmark                       Mode  Cnt      Score     Error  Units
> LocaleCache.testForLanguageTag  avgt   20   4801.175 ± 371.830  ns/op
> LocaleCache.testLocaleOf        avgt   20  60394.652 ± 352.471  ns/op

Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:

  Addressing comments (test grouping, synchronization), minor optimization on loop lookup

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14404/files
  - new: https://git.openjdk.org/jdk/pull/14404/files/06d199dc..fb1535ff

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14404&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14404&range=00-01

  Stats: 55 lines in 2 files changed: 16 ins; 14 del; 25 mod
  Patch: https://git.openjdk.org/jdk/pull/14404.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14404/head:pull/14404

PR: https://git.openjdk.org/jdk/pull/14404


More information about the core-libs-dev mailing list