RFR: 8307508: IndirectVarHandle.isAccessModeSupported throws NPE [v3]

Mandy Chung mchung at openjdk.org
Mon Jun 12 23:55:40 UTC 2023


On Mon, 12 Jun 2023 23:17:03 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/jdk/java/lang/invoke/VarHandles/IndirectVarHandleTest.java line 44:
>> 
>>> 42:         var lookup = MethodHandles.lookup();
>>> 43:         var intArrayVh = MethodHandles.arrayElementVarHandle(int[].class);
>>> 44:         var addOne = lookup.bind((IntUnaryOperator) a -> a + 1, "applyAsInt", MethodType.methodType(int.class, int.class));
>> 
>> Nit: a couple of long lines (L44, 48 and 55) can be wrapped into separate line.
>
> Done in a second push. Also wrapped the summary line (which was too long) from your suggestion patch.

Looks good.  thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14409#discussion_r1227349773


More information about the core-libs-dev mailing list