RFR: 8281658: Add a security category to the java -XshowSettings option [v2]

[Roger Riggs]

On Tue, 13 Jun 2023 13:57:13 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

>> New functionality in the -XshowSettings menu to display relevant information about JDK security configuration
>
> Sean Coffey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into 8281658-showsettings-security
>  - Incorporate feedback to date
>  - minor edits, copyright, descriptions etc
>  - Merge branch 'master' into 8281658-showsettings-security
>  - Merge branch 'master' into 8281658-showsettings-security
>  - 8281658

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 189:

> 187:                 } else {
> 188:                     printSecuritySettings("all");
> 189:                 }

Perhaps a slight preference for:

            var opt = opts.length > 2 ? opts[2].trim() : "all";
            printSecuritySettings(opt);

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 342:

> 340: 
> 341:     private static void printSecuritySettings(String arg) {
> 342:         switch (arg.toLowerCase(Locale.ROOT)) {

Drop the conversion to lower case: none of the other categories allow "sloppy-case" inputs.

src/java.base/share/classes/sun/launcher/LauncherHelper.java line 422:

> 420:             ostream.println(TWOINDENT + "Provider name: " + p.getName());
> 421:             if (verbose) {
> 422:                 ostream.println(TWOINDENT + PROV_INFO_STRING + wrappedString(p.getInfo(), 80));

Wrapping the args at 80 might still produce line that is quite long.
Perhaps wrap the string after it was concatenated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1228227964
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1228187867
PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1228270167