RFR: 8308609: java/lang/ScopedValue/StressStackOverflow.java fails with "-XX:-VMContinuations" [v6]

Tue Jun 13 15:53:21 UTC 2023

On Tue, 13 Jun 2023 15:53:07 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Move `runWith()` from `VirtualThread` to `BaseVirtualThread`.
>> 
>> `BoundVirtualThread` does not use `runWith()` to run its task, so when a VM error occurs it can not recover scoped values.
>> 
>> Moving `runWith()` into the common subclass of both `VirtualThread` and `BoundVirtualThread` fixes the problem.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   One other thing

The implementation changes look good.

The update to test looks okay too although I would like to see if we can do better in SVC and STS when there is a SO.  In passing, I think all usages of tlr should be replaced with ThreadLocalRandom.current().

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14399#pullrequestreview-1477540790