RFR: 8309819: Fix specification about descriptor inverses in Class and MethodType [v3]

Chen Liang liach at openjdk.org
Wed Jun 14 01:34:40 UTC 2023


> The API specification for descriptorString not being a strict inverse of Class::forName and MethodType::fromDescriptorString are not entirely correct.
> 
> 1. Class::descriptorString was never an inverse of Class::forName, which takes a binary name instead. Class::getName was a partial inverse instead.
> 2. MethodType::toMethodDescriptorString ends with a meaningless sentence: "fromMethodDescriptorString, because the latter requires a suitable class loader argument.", and the "Note:" section can be replaced with an `@apiNote`.
> 3. Both of these didn't mention hidden classes (or other non-nominally-describable classes) as a reason that prevents the inversion operation, in addition to distinct classloaders.
> 
> A few user-defined anchor links are replaced with updated javadoc link tag format as well. The explicit html-style links in `@see` tags are unchanged in order to retain the non-code output.
> 
> The rendered specifications:
> https://cr.openjdk.org/~liach/8309819/00/java.base/java/lang/Class.html
> https://cr.openjdk.org/~liach/8309819/00/java.base/java/lang/invoke/MethodType.html

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Address the other two review comments
 - Merge branch 'fix/descstring-spec' of https://github.com/liachmodded/jdk into fix/descstring-spec
 - Update src/java.base/share/classes/java/lang/Class.java
   
   Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
 - Merge branch 'master' into fix/descstring-spec
 - 8309819: Fix specification about descriptor inverses in Class and MethodTypeDesc

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14411/files
  - new: https://git.openjdk.org/jdk/pull/14411/files/d30bb237..c49c809b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14411&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14411&range=01-02

  Stats: 10995 lines in 323 files changed: 2578 ins; 7312 del; 1105 mod
  Patch: https://git.openjdk.org/jdk/pull/14411.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14411/head:pull/14411

PR: https://git.openjdk.org/jdk/pull/14411


More information about the core-libs-dev mailing list