RFR: 8310053: VarHandle and slice handle derived from layout are lacking alignment check [v3]
Jorn Vernee
jvernee at openjdk.org
Wed Jun 14 23:38:03 UTC 2023
On Wed, 14 Jun 2023 22:28:38 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Add missing alignment checks for the alignment constraint of the root layout of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle `MemoryLayout::sliceHandle`.
>>
>> Testing: `jdk_foreign` test suite
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> formatting
I've switched to `expectThrows`. As discussed offline, I've also dropped the alignment check from the inner accessed element, as this is redundant due to layouts enforcing alignment of nested elements already. So, if the root layout is aligned, so is the element. (this turned out to be simper than I initially thought)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14475#issuecomment-1592124134
More information about the core-libs-dev
mailing list