RFR: 8310105: LoongArch64 builds are broken after JDK-8304913

Aleksey Shipilev shade at openjdk.org
Thu Jun 15 08:15:59 UTC 2023


On Thu, 15 Jun 2023 04:40:59 GMT, Ao Qi <aoqi at openjdk.org> wrote:

> LoongArch64 Zero builds are broken after [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913):
> 
> jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum constant jdk.internal.util.Architecture.LOONGARCH64
> at jdk.jlink/jdk.tools.jlink.builder.DefaultImageBuilder.storeFiles(DefaultImageBuilder.java:181)
> at jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.storeFiles(ImagePluginStack.java:486)
> at jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.writeImage(ImageFileCreator.java:168)
> at jdk.jlink/jdk.tools.jlink.internal.ImageFileCreator.create(ImageFileCreator.java:100)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask$ImageHelper.retrieve(JlinkTask.java:860)
> at jdk.jlink/jdk.tools.jlink.internal.ImagePluginStack.operate(ImagePluginStack.java:194)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.createImage(JlinkTask.java:423)
> at jdk.jlink/jdk.tools.jlink.internal.JlinkTask.run(JlinkTask.java:286)
> at jdk.jlink/jdk.tools.jlink.internal.Main.run(Main.java:56)
> at jdk.jlink/jdk.tools.jlink.internal.Main.main(Main.java:34)
> Error: jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum constant jdk.internal.util.Architecture.LOONGARCH64
> 
> 
> Builds tested: LoongArch64 Zero, both release and fastdebug.
> 
> If this patch conflicts with #14471, I will rebase after #14471 is integrated.

Looks okay, thanks!

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14482#pullrequestreview-1480966009


More information about the core-libs-dev mailing list