RFR: 8310053: VarHandle and slice handle derived from layout are lacking alignment check [v4]

Jorn Vernee jvernee at openjdk.org
Thu Jun 15 13:08:49 UTC 2023


On Wed, 14 Jun 2023 23:38:01 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Add missing alignment checks for the alignment constraint of the root layout of a VarHandle created through `MemoryLayout::varHandle` and a MethodHandle `MemoryLayout::sliceHandle`.
>> 
>> Testing: `jdk_foreign` test suite
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Drop alignment checks from accessed elements
>   Use expectThrows

I've gone ahead and implemented this. I also added a test to make sure that alignment checks still happen when using deref path elements.

I also fixed a minor javadoc issue, in the doc for varHandle. It said that we checked the alignment of the accessed address, but we check the alignment of the base address (a term which is defined earlier).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14475#issuecomment-1593004135


More information about the core-libs-dev mailing list