RFR: 8310033: Clarify return value of Java Time compareTo methods
Brian Burkhalter
bpb at openjdk.org
Fri Jun 16 20:33:09 UTC 2023
On Wed, 14 Jun 2023 20:35:54 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> In java.time packages, clarify timeline order javadoc to mention "before" and "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater than zero" in javadoc @return
> The term "positive" is ambiguous, zero is considered positive and indicates equality.
Looks good.
-------------
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14479#pullrequestreview-1484337195
More information about the core-libs-dev
mailing list