RFR: 8310242: Clarify the name parameter to Class::forName [v4]
Chen Liang
liach at openjdk.org
Sun Jun 18 23:12:25 UTC 2023
On Sun, 18 Jun 2023 18:36:28 GMT, Jens Lidestrom <duke at openjdk.org> wrote:
>> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> missing 'L' for the array class name
>
> src/java.base/share/classes/java/lang/Class.java line 395:
>
>> 393: * attached thread), the system class loader is used.
>> 394: *
>> 395: * @param className the <a href="#binary-name">binary name</a> of the class
>
> The new text is probably more correct, but it is less easy to understand. I think "fully qualified name" of a class is a well-known term, but "binary name" is rather unknown.
>
> I suggest changing the text to mention both terms. For example like this:
>
> Suggestion:
>
> * @param className the <a href="#binary-name">binary name</a>) of the class, for example its fully qualified name
Binary name is defined in JLS. Fully qualified name is ambiguous as it may refer to the internal name or a descriptor string.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14528#discussion_r1233401865
More information about the core-libs-dev
mailing list