RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

Sean Coffey coffeys at openjdk.org
Mon Jun 19 16:15:19 UTC 2023


On Sat, 17 Jun 2023 01:51:36 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Sean Coffey has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Pass PrintStream to security helper
>
> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 93:
> 
>> 91:         for (String key : p.stringPropertyNames().stream().sorted().toList()) {
>> 92:             String val = p.getProperty(key);
>> 93:             if (val.contains(",") && val.length() > 60) {
> 
> Do you want to do the same for `;`? `jceks.key.serialFilter` uses it.

fair point. done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14394#discussion_r1234252148


More information about the core-libs-dev mailing list