RFR: 8309191: Reduce JDK dependencies of cgroup support

Andrew Dinn adinn at openjdk.org
Tue Jun 20 09:10:09 UTC 2023


On Tue, 13 Jun 2023 15:48:31 GMT, Christian Wimmer <cwimmer at openjdk.org> wrote:

> We (as the Native Image team) are OK with this. Our testing will detect that pretty quickly, and then the new code can be fixed.

That may well be the case. However, until all the concerns raised by OpenJDK reviewers who have looked at this PR are addressed to their satisfaction it would not be appropriate to merge this patch.

n.b. That does not automatically mean the course of action the reviewers have recommended has to be followed. A resolution needs to be negotiated according to the merits and risks of the change. However, regarding that negotiation, I'll observe that the (repeated) request to break this change down in several steps appears to me to be motivated by the desire to ensure that the merits of the change are maximized (no unnecessary loss of important functionality) and the risks minimized (no unnecessary perturbation of the current implementation) -- which is not an unusual way for OpenJDK reviewers to proceed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14216#issuecomment-1598400830


More information about the core-libs-dev mailing list