RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Jun 21 08:06:16 UTC 2023


On Wed, 21 Jun 2023 07:55:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I'm not aware of any other uses either; its not intended to be used outside of ProcessImpl especially since the addition of the new protocol to communicate parameters and confirm launching of the child.
>
> This curiosity has been present since Rob's first version:
> https://mail.openjdk.org/pipermail/core-libs-dev/2012-November/012417.html

I assumed that at some point in its life, maybe just in the first unpublished versions, the jspawnhelper had a variable number of arguments, possibly from different callers. But the fd-string was always supposed to be the last one. Then this would have made perfect sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14531#discussion_r1236569635


More information about the core-libs-dev mailing list