RFR: JDK-8310380: Handle problems in core-related tests on macOS when codesign tool does not work [v3]

Christoph Langer clanger at openjdk.org
Thu Jun 22 12:23:07 UTC 2023


On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently, a number of tests fail on macOS because they miss the core file (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not work ("checking if debug mode codesign is possible... no) .
>> So adding the needed entitlement to generate cores is not done in the build. This is currently not checked later in the tests.
>> But without the entitlement, a core is not generated.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move javaPath into caller

Looks good to me now.

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14562#pullrequestreview-1493063728


More information about the core-libs-dev mailing list