RFR: 8308780: Fix the Java Integer types on Windows [v6]

Julian Waters jwaters at openjdk.org
Thu Jun 22 13:52:12 UTC 2023


On Thu, 22 Jun 2023 10:37:11 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Julian Waters has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Revert NULL to nullptr changes in jaccesswalker
>
> src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalker.cpp line 547:
> 
>> 545:         snprintf( s, sizeof(s),
>> 546:             "ERROR calling GetAccessibleContextInfo; vmID = %lX, context = %p",
>> 547:             reinterpret_cast<unsigned long>(vmID), (void*)context );
> 
> do you need this cast? I checked a few compilers and passing a signed long to "%lX" was fine with them.

gcc will crash with a warning about a mismatched format specifier between signed and unsigned if this isn't done, unfortunately

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1238560245


More information about the core-libs-dev mailing list