RFR: 8308780: Fix the Java Integer types on Windows [v9]
Julian Waters
jwaters at openjdk.org
Thu Jun 22 15:12:06 UTC 2023
On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64 respectively. In particular, the former is rather problematic since it breaks compilation as the Visual C++ becomes stricter and more compliant with every release, which means the way Windows code treats long as a typedef for int is no longer correct, especially with -permissive- enabled. Instead of changing every piece of broken code to match the jint = long typedef, which is far too time consuming, we can instead change jint to an int (which is still the same 32 bit number type as long), as there are far fewer problems caused by this definition. It's better to get this over and done with sooner than later when a future version of Visual C++ finally starts to break on existing code
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert "GetDIBits should take an LPVOID"
>
> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac.
Will do, thanks Daniel
@prrace @dholmes-ora Are both of you happy with the changes?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14125#issuecomment-1602811926
More information about the core-libs-dev
mailing list