RFR: 8310234: Refactor Locale tests to use JUnit [v2]
Justin Lu
jlu at openjdk.org
Thu Jun 22 18:55:32 UTC 2023
On Thu, 22 Jun 2023 18:30:55 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> test/jdk/java/util/Locale/LocaleConstructors.java line 51:
>>
>>> 49: public void langTest() {
>>> 50: Locale aLocale = Locale.of(LANG);
>>> 51: Locale otherLocale = new Locale(LANG);
>>
>> Is there a preference on testing code that is marked as `@deprecated` in the JDK? This test originally validated the parameters of the deprecated Locale constructor but was changed in 2022 with the Locale.of() method. However, the test was originally meant to test the constructor so I re-inserted it here.
>
> If the functionality still exists we should keep the existing test(s)
Got it, will leave it in then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14609#discussion_r1238912827
More information about the core-libs-dev
mailing list