RFR: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer [v2]

Brian Burkhalter bpb at openjdk.org
Thu Jun 22 21:28:04 UTC 2023


On Thu, 22 Jun 2023 21:21:56 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> src/java.base/share/classes/java/io/Reader.java line 193:
>> 
>>> 191:      * changes made are the results of a put operation. No flipping or
>>> 192:      * rewinding of the buffer is performed.  If the specified character
>>> 193:      * buffer is full, then no characters will be read and zero will be
>> 
>> Instead of "is full" here, it would be more consistent to state "has no remaining elements".
>
> For a buffer that is being written into, it sounds a bit odd to say "no remaining elements"; that phrasing is ok for reading/getting bytes but doesn't sound like there's free space to put anything.
> 
> Would "no remaining free elements" or "no remaining available elements" be better?

Or "no remaining space" / "no space remaining"?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14616#discussion_r1239045510


More information about the core-libs-dev mailing list