RFR: 8308780: Fix the Java Integer types on Windows [v9]
Julian Waters
jwaters at openjdk.org
Fri Jun 23 00:16:09 UTC 2023
On Thu, 22 Jun 2023 19:20:09 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert "GetDIBits should take an LPVOID"
>>
>> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac.
>
> src/java.desktop/windows/native/libawt/java2d/windows/GDIRenderer.cpp line 325:
>
>> 323: }
>> 324:
>> 325: jint sx, sy, ex, ey;
>
> I agree with David, these should have type `int` as accepted by the [`::Arc`](https://learn.microsoft.com/en-us/windows/win32/api/wingdi/nf-wingdi-arc) function. However, the `AngleToCoord` function is declared with `jint` as parameters.
>
> https://github.com/openjdk/jdk/blob/84f8e08c2ecc90ec50a13406fb99b8cd52f33b7c/src/java.desktop/windows/native/libawt/java2d/windows/GDIRenderer.cpp#L52
>
> Its declaration can be changed to `int`, it's an internal function used by `*_doDrawArc` and `*_doFillArc`.
Resolved, will push soon
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239142969
More information about the core-libs-dev
mailing list