RFR: 8308780: Fix the Java Integer types on Windows [v11]

Daniel Jeliński djelinski at openjdk.org
Fri Jun 23 06:13:07 UTC 2023


On Fri, 23 Jun 2023 02:38:13 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> On Windows, the basic Java Integer types are defined as long and __int64 respectively. In particular, the former is rather problematic since it breaks compilation as the Visual C++ becomes stricter and more compliant with every release, which means the way Windows code treats long as a typedef for int is no longer correct, especially with -permissive- enabled. Instead of changing every piece of broken code to match the jint = long typedef, which is far too time consuming, we can instead change jint to an int (which is still the same 32 bit number type as long), as there are far fewer problems caused by this definition. It's better to get this over and done with sooner than later when a future version of Visual C++ finally starts to break on existing code
>
> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert wrong Copyright
>  - Copyright

src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76:

> 74:     /*for multifont menu */
> 75:     BOOL IsTopMenu();
> 76:     virtual AwtMenuItem* GetItem(jobject target, int index);

Hi @aivanov-jdk are you OK leaving this inconsistent with the definition?
https://github.com/openjdk/jdk/blob/16b5a91461db1765e2e7596ebaaf1299cec9b0c8/src/java.desktop/windows/native/libawt/windows/awt_Menu.cpp#L261

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1239358334


More information about the core-libs-dev mailing list