RFR: 8308780: Fix the Java Integer types on Windows [v11]
Alexey Ivanov
aivanov at openjdk.org
Fri Jun 23 16:56:10 UTC 2023
On Fri, 23 Jun 2023 14:30:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> To minimise the number of changes, we can go for using `jint` in `AwtMenu::GetItem`.
>>
>> What do you thing, @djelinski and @TheShermanTanker?
>
> Hmm, I lean towards jint as I feel it conveys the fact that it is a Java parameter clearer, intuitively to me it makes sense that a Java integer type would still work in a C++ for loop in native code
You're right… it gives a hint it'll be an upcall into Java. Let's go for `jint` then.
I don't think there's a need to change the type of the for-loop variable to `jint`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14125#discussion_r1240041248
More information about the core-libs-dev
mailing list