RFR: 8310405: Linker.Option.firstVariadicArg should specify which index values are valid [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Fri Jun 23 17:30:08 UTC 2023
On Fri, 23 Jun 2023 17:24:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>>
>> polish doc, review comments
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 659:
>
>> 657: * It is important to always use this linker option when linking a <a href=Linker.html#variadic-funcs>variadic
>> 658: * function</a>, even when none of the arguments are passed as variadic arguments (the second case in the list
>> 659: * above), as this affects the linking process on certain platforms.
>
> Suggestion:
>
> * above), as this might still affect the calling convention on certain platforms.
Note: we use the term calling convention in Linker javadoc - I think it's slightly more precise than "linking process".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14565#discussion_r1240083929
More information about the core-libs-dev
mailing list