RFR: 8222329: Readable read(CharBuffer) does not specify that 0 is returned when there is no remaining space in buffer [v6]
Roger Riggs
rriggs at openjdk.org
Fri Jun 23 20:40:17 UTC 2023
On Fri, 23 Jun 2023 17:19:10 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Clarify the behavior of `java.lang.Readable` when the specified `java.nio.CharBuffer` parameter is empty but read-only, and when it is full.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8222329: Remove redundancy of length vs. remaining in CharBuffer::read doc
Looks good but for one typo.
src/java.base/share/classes/java/io/Reader.java line 194:
> 192: * rewinding of the buffer is performed. If the specified character
> 193: * buffer has no space {@linkplain java.nio.Buffer#hasRemaining
> 194: * remaining} or or its {@linkplain java.nio.CharBuffer#length length}
typo: "or or" -> "or"
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14616#pullrequestreview-1495972372
PR Review Comment: https://git.openjdk.org/jdk/pull/14616#discussion_r1240353636
More information about the core-libs-dev
mailing list