RFR: 8308452: Extend internal Architecture enum with byte order and address size [v6]
Jaikiran Pai
jpai at openjdk.org
Mon Jun 26 10:54:07 UTC 2023
On Thu, 22 Jun 2023 19:24:37 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The internal enum jdk.internal.util.Architecture does not provide information about the big or little endianness or the address size (64 or 32 bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The values of the enum are extended to separately identify the big endian and little-endian uses of the ISA.
>> For example, `PPC64` and `PPC64LE` for the big and little-endian versions.
>> The enum values directly reflect the build-time artifacts and resulting executables.
>>
>> This information about an architecture will make the enum more useful especially to identify a target platform in a cross-platform use case. A method is added to map well known aliases for the platforms to the Architecture enum.
>
> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>
> - Refactored test to make it easier to add new Architectures
> - Merge branch 'master' into 8308452-cross-platform-arch
> - Merge branch 'master' into 8308452-cross-platform-arch
> - Remove duplicate import
> - Don't map ppc64le to ppc64 when processing the PlatformProps.java.template
> - Merge branch 'master' into 8308452-cross-platform-arch
> - Correct handling of ppc64le/ppc64 using non-canonical architecture.
> Keep canonical architecture names for s390, amd/x86_64.
> - Merge branch 'master' into 8308452-cross-platform-arch
> - Merge branch 'master' into 8308452-cross-platform-arch
> - Review suggestions
> - ... and 2 more: https://git.openjdk.org/jdk/compare/72501cf7...2e04a1ca
src/java.base/share/classes/jdk/internal/util/Architecture.java line 60:
> 58:
> 59: /**
> 60: * Construct an Arctecture with number of address bits and byte order.
Hello Roger, there is a typo here "Arctecture" instead of "Architecture"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14063#discussion_r1241997511
More information about the core-libs-dev
mailing list