RFR: 8308899: Introduce Classfile.Context and improve Classfile.Option(s) [v25]

Chen Liang liach at openjdk.org
Mon Jun 26 14:59:24 UTC 2023


On Mon, 26 Jun 2023 13:33:38 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Classfile context object and multi-state options have been discussed at https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all affected code across JDK sources and tests.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8308646: Typo in ConstantValueAttribute

I ran `make docs-classfile-api-javadoc` and the results look good in general. There are a few spec and API issues scattered across the whole API, which I think I will probably collect and list them in the mailing list later.

One thing of note is that the JDK itself has a `@sealedGraph` taglet to render the sealed class hierarchy of any class. We might want to add that tag to all our sealed public classes or interfaces. But it requires a somewhat more complicated build process (including generating dot files with graphviz and rendering them to svg) and you might tweak the `SetupExecute` to a full-on `SetupApiDocsGeneration`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14180#issuecomment-1607661040


More information about the core-libs-dev mailing list