RFR: 8308899: Introduce Classfile context and improve Classfile options [v25]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Jun 26 15:43:13 UTC 2023
On Mon, 26 Jun 2023 15:39:15 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> The API changes look great. I like the instance usages of ClassFile, and how CF is now used in a centralized fashion to double down as a cache/option store (and entry point for transformation). Seems like a step in a good direction, and make the API feel a little more cohesive.
>
> A small subjective comment - I'm not too fond of using "context" as a variable/accessor name for all the places where we use a classfile. E.g. if classfile is the context, perhaps these variable/accessor should just be named "classfile" ?
Also, another observation: the number of updates snippets in javadoc seems rather low for something that touches the main entry point by which client interacts with classfiles. This seems a sign of perhaps not having many end to end examples in the API javadoc?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/14180#issuecomment-1607741386
More information about the core-libs-dev
mailing list