RFR: 8308452: Extend internal Architecture enum with byte order and address size [v7]
Mandy Chung
mchung at openjdk.org
Mon Jun 26 17:53:05 UTC 2023
On Mon, 26 Jun 2023 14:57:11 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The internal enum jdk.internal.util.Architecture does not provide information about the big or little endianness or the address size (64 or 32 bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The values of the enum are extended to separately identify the big endian and little-endian uses of the ISA.
>> For example, `PPC64` and `PPC64LE` for the big and little-endian versions.
>> The enum values directly reflect the build-time artifacts and resulting executables.
>>
>> This information about an architecture will make the enum more useful especially to identify a target platform in a cross-platform use case. A method is added to map well known aliases for the platforms to the Architecture enum.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix typo
This change looks fine to me.
-------------
Marked as reviewed by mchung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14063#pullrequestreview-1499090206
More information about the core-libs-dev
mailing list