RFR: 8310241: OffsetDateTime compareTo redundant computation

[Roger Riggs]

On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`. 
> If the `compareInstant` utility method returns 0 (equal), it compares the `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it found equal, the `compareTo` method unnecessarily does it again.
> The code is refactored in `compareInstant` to do the comparison of `LocalDateTime` exactly once, if it is needed.
> 
> This case is covered by existing tests in test/jdk/java/time/tck/java/time/TCKOffsetDateTime.java

Closing because this 'fix' a bigger issue than it fixes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14618#issuecomment-1608191784