RFR: 8310849: Pattern matching for instanceof and arrayType cleanup in j.l.invoke and j.l.reflect [v3]

Chen Liang liach at openjdk.org
Mon Jun 26 22:02:29 UTC 2023


On Mon, 26 Jun 2023 18:28:06 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify equals by replacing if with and operators
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 899:
> 
>> 897:             return equals(mt);
>> 898:         }
>> 899:         if (x instanceof ConcurrentWeakInternSet.WeakEntry<?> e && e.get() instanceof MethodType mt) {
> 
> Nit: break this long line into 2.

Done. Thanks for the review and suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14642#discussion_r1242859467


More information about the core-libs-dev mailing list