RFR: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString [v6]

[Chen Liang]

On Mon, 26 Jun 2023 18:53:42 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Review and updates for 8310242
>>  - Merge branch 'master' into fix/descstring-spec
>>  - Update the note for getName
>>  - Convert the note in fromDescriptorString to apiNote
>>  - Address the other two review comments
>>  - Merge branch 'fix/descstring-spec' of https://github.com/liachmodded/jdk into fix/descstring-spec
>>  - Update src/java.base/share/classes/java/lang/Class.java
>>    
>>    Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>>  - Merge branch 'master' into fix/descstring-spec
>>  - 8309819: Fix specification about descriptor inverses in Class and MethodTypeDesc
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line 1229:
> 
>> 1227:      *
>> 1228:      * @apiNote
>> 1229:      * This is not a strict inverse of {@link #fromMethodDescriptorString
> 
> Re-reading this, I think this api note reads fine.   OTOH I find a little confusing how you rephrased it.  "A method type produced by changing a component class object to...".   I understand you tried to make it crystal clear two method types may have the identical descriptor strings even if its parameter type or return type are distinct Class objects.   
> 
> I think the original version is clear enough and less lengthy.

* Two distinct classes which share a common name but have different class loaders
     * produce identical component descriptors in descriptor strings.

Does this sound good? This also addresses alan's wording concerns.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14411#discussion_r1242871605