RFR: 8301569: list mode of jmod and jimage cannot be used normally in turkish locale

Glavo duke at openjdk.org
Tue Jun 27 08:04:04 UTC 2023


On Wed, 7 Jun 2023 06:32:31 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Sounds fine to me and as other have agreed `Locale.ROOT` would be more appropriate. Would you be willing to update this PR to update the few other occurences in some classes (`JImageTask`, `JlinkTask` and `VersionPropsPlugin`) as noted by Mandy and Alan in their comments?

I think in most cases, there is no difference in the effect between `toUpperCase(Locale.ROOT)` and `toUpperCase(Locale.ENGLISH)`.

If you think it is appropriate to replace `Locale.ENGLISH` with `Locale.ROOT` in this PR, I can do so. I believe that compared to `Locale.ENGLISH`, the `Locale.ROOT is more suitable for use in more places.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12281#issuecomment-1608995613


More information about the core-libs-dev mailing list