RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v26]
温绍锦
duke at openjdk.org
Tue Jun 27 16:18:19 UTC 2023
On Tue, 27 Jun 2023 13:54:43 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix UUID.java import, rename jdk.util.HexDigits to jdk.util.Hex256 and make private constructor.
>
> src/java.base/share/classes/jdk/internal/util/Hex256.java line 31:
>
>> 29:
>> 30: /**
>> 31: * Provides a hexadecimal cache array of values from 0 to 255
>
> A bit more information about the contents and use would be useful for future developers and perhaps an example of the use so they don't have to go find where it is used and decipher the code.
> Each element contains the ascii encoded hex characters for the index. It may be obvious which character is the low nibble for the low byte but it might be good to say so.
comments have been added, including usage examples.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1244014708
More information about the core-libs-dev
mailing list