RFR: 8301569: jmod list option and jimage list --help not interpreted correctly on turkish locale [v4]

Jaikiran Pai jpai at openjdk.org
Wed Jun 28 08:58:09 UTC 2023


On Tue, 27 Jun 2023 15:20:33 GMT, Glavo <duke at openjdk.org> wrote:

>> When the default Locale is `tr`, the jmod and jimage commands have the following problems:
>> 
>> * The jmod command does not correctly recognize the `list` mode typed in lowercase;
>> * The jimage command cannot obtain the help information of the `list` mode.
>
> Glavo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update JImageTask, JlinkTask and VersionPropsPlugin

Marked as reviewed by jpai (Reviewer).

Thank you Glavo for these changes. The latest changes look good to me. I see that others more familiar with this code have approved the current state of the PR. I'll run some internal tests just to make sure nothing unexpectedly breaks, before sponsoring this today.

-------------

PR Review: https://git.openjdk.org/jdk/pull/12281#pullrequestreview-1502611452
PR Comment: https://git.openjdk.org/jdk/pull/12281#issuecomment-1611025979


More information about the core-libs-dev mailing list