RFR: 8311020: Typo cleanup in Classfile API [v2]

Chen Liang liach at openjdk.org
Wed Jun 28 14:12:15 UTC 2023


On Wed, 28 Jun 2023 08:56:28 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix classfile test typos detected by IDE, fix tests
>
> src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrinterImpl.java line 500:
> 
>> 498:             case OfClass clv -> leafs("class", clv.className().stringValue());
>> 499:             case OfEnum ev -> leafs("enum class", ev.className().stringValue(),
>> 500:                                     "constant name", ev.constantName().stringValue());
> 
> Here the same typo is repeated in ClassPrinterTest, which actually fails after the fix.

Thanks for the reminder. I've checked IDE-reported typos in the tests and fixed 2; jdk.classfile tests pass on my machine now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14687#discussion_r1245272265


More information about the core-libs-dev mailing list