RFR: 8311020: Typo cleanup in Classfile API [v2]

Adam Sotona asotona at openjdk.org
Wed Jun 28 16:19:57 UTC 2023


On Wed, 28 Jun 2023 14:12:12 GMT, Chen Liang <liach at openjdk.org> wrote:

>> This is a cleanup patch that fixes:
>> 1. `ClassfileBuilder` should be sealed but was not; it's now sealed.
>> 2. Various typo fixes, including spelling errors, wrong descriptions, and unnecessary full qualifications for classes in the same package.
>> 
>> Requesting a review from @asotona. There's a few other more complex issues discovered, which I will describe on the mailing list to elicit a discussion for best solutions.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix classfile test typos detected by IDE, fix tests

Thank you for fixing the typos.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14687#pullrequestreview-1503501942


More information about the core-libs-dev mailing list