RFR: 8310033: Clarify return value of Java Time compareTo methods [v4]
Roger Riggs
rriggs at openjdk.org
Wed Jun 28 20:22:01 UTC 2023
> In java.time packages, clarify timeline order javadoc to mention "before" and "after" in the value of the `compareTo` method return values.
> Add javadoc @see tags to isBefore and isAfter methods
>
> Replace use of "negative" and positive with "less than zero" and "greater than zero" in javadoc @return
> The term "positive" is ambiguous, zero is considered positive and indicates equality.
Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
Improve descriptions to be more specific and remove inappropriate use of before/after
Remove extra blank lines
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14479/files
- new: https://git.openjdk.org/jdk/pull/14479/files/a0acac19..62f01b5d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14479&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14479&range=02-03
Stats: 16 lines in 9 files changed: 0 ins; 3 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/14479.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14479/head:pull/14479
PR: https://git.openjdk.org/jdk/pull/14479
More information about the core-libs-dev
mailing list