RFR: 8311085: Remove implementation detail writeTo from LocalVariable(Type) [v3]
Chen Liang
liach at openjdk.org
Fri Jun 30 00:51:42 UTC 2023
> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which should be implementation details.
>
> See https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html for context.
>
> This patch moves the implementation to `DirectCodeBuilder`'s original use sites; the old `b.canWriteDirect` branch is redundant, as `writeIndex`'s implementation already performs such an optimization.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Fix line ending, update corpus test
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/14705/files
- new: https://git.openjdk.org/jdk/pull/14705/files/7d9a87e2..a2e604eb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=14705&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=14705&range=01-02
Stats: 78 lines in 2 files changed: 1 ins; 2 del; 75 mod
Patch: https://git.openjdk.org/jdk/pull/14705.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/14705/head:pull/14705
PR: https://git.openjdk.org/jdk/pull/14705
More information about the core-libs-dev
mailing list